terrymanu commented on PR #38758: URL: https://github.com/apache/shardingsphere/pull/38758#issuecomment-4577157328
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** PR #38758 latest head `7b21819cb83731e5fd0457c10583f214ce078b5b`; base `master` at `8bfd71e786ffc1379fca6353225b9ef134479cd1`; local merge-base `8bfd71e786ffc1379fca6353225b9ef134479cd1`. Reviewed the four changed docs files from GitHub `/pulls/38758/files`, and the local triple-dot file list matched GitHub exactly. - **Not Reviewed Scope:** No production code, tests, rendered Hugo site output, GitHub Actions, or CI/check-run status reviewed. - **Need Expert Review:** No dedicated security, concurrency, performance, protocol, or SQL dialect expert review is required for this docs-only clarification. ### Basis - The PR directly addresses its stated goal: it clarifies that ShardingSphere-MCP is the access path used by models and agents, not a model-to-database direct connection path (`docs/document/content/user-manual/shardingsphere-mcp/_index.en.md:9`, `docs/document/content/user-manual/shardingsphere-mcp/client-integration.en.md:7`, with matching CN updates). - The new wording remains consistent with the existing capability boundary: query SQL and side-effecting SQL are still separated by documented tools and safety gates (`docs/document/content/user-manual/shardingsphere-mcp/capabilities.en.md:65`). - Adjacent configuration docs still explain that `runtimeDatabases` may point to Proxy logical databases or physical JDBC targets with different semantics, so the overview wording does not remove the existing target-boundary guidance (`docs/document/content/user-manual/shardingsphere-mcp/configuration.en.md:41`). - No API, SPI, config, parser, routing, metadata assembly, high-frequency execution path, dependency, or runtime behavior changes are introduced. - No unrelated changes were found in the reviewed PR file scope. ### Verification - `curl -sS https://api.github.com/repos/apache/shardingsphere/pulls/38758` exited `0`; reviewed latest PR metadata and head SHA. - `curl -sS https://api.github.com/repos/apache/shardingsphere/pulls/38758/files?per_page=100` exited `0`; GitHub reported the same four changed docs files. - `git fetch apache master:refs/remotes/apache/master pull/38758/head:refs/remotes/apache/pr/38758` exited `0`. - `git diff --name-status 8bfd71e786ffc1379fca6353225b9ef134479cd1..refs/remotes/apache/pr/38758` exited `0`; local file list matched GitHub `/pulls/38758/files`. - `git diff --check 8bfd71e786ffc1379fca6353225b9ef134479cd1..refs/remotes/apache/pr/38758 -- docs/document/content/user-manual/shardingsphere-mcp/_index.cn.md docs/document/content/user-manual/shardingsphere-mcp/_index.en.md docs/document/content/user-manual/shardingsphere-mcp/client-integration.cn.md docs/document/content/user-manual/shardingsphere-mcp/client-integration.en.md` exited `0`. - No Maven, Spotless, Checkstyle, or Hugo build was run by the reviewer because this round only changes prose in documentation and no files were modified locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
