terrymanu commented on PR #38773: URL: https://github.com/apache/shardingsphere/pull/38773#issuecomment-4600305336
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** Latest PR head `08f5bc81ace30affefbdb1add33a11942aa60c26`; local merge-base `5868bfb0cb9fa0ac556fc31f69d9335bf5e6f238`; GitHub `/pulls/38773/files` matched the local triple-dot diff exactly. Reviewed `docs/document/content/user-manual/shardingsphere-mcp/configuration.cn.md` and `docs/document/content/user-manual/shardingsphere-mcp/configuration.en.md`. - **Not Reviewed Scope:** CI/check-run status was intentionally not reviewed. No runtime code path, parser behavior, API/SPI, dependency, or generated site rendering was changed. - **Need Expert Review:** No. This is a localized documentation formatting correction for MCP configuration fields. ### Basis - The root cause is directly fixed: the copied field-name code span no longer includes required/optional marker text. For example, `docs/document/content/user-manual/shardingsphere-mcp/configuration.en.md:56` now renders the field name as `databaseType`, with `(+ )`-style marker text outside the code span; the Chinese page mirrors the same correction at `docs/document/content/user-manual/shardingsphere-mcp/configuration.cn.md:56`. - The required/optional semantics are preserved. The documentation still marks `databaseType`, `jdbcUrl`, `username`, and `driverClassName` as required, and `password` as optional, which matches the runtime YAML validation in `mcp/bootstrap/src/main/java/org/apache/shardingsphere/mcp/bootstrap/config/yaml/config/YamlRuntimeDatabaseConfiguration.java:33` and the password defaulting path in `mcp/bootstrap/src/main/java/org/apache/shardingsphere/mcp/bootstrap/config/yaml/swapper/YamlRuntimeDatabaseConfigurationSwapper.java:44`. - The English and Chinese pages remain aligned, and the local legend still explains both markers at `docs/document/content/user-manual/shardingsphere-mcp/configuration.en.md:64` and `docs/document/content/user-manual/shardingsphere-mcp/configuration.cn.md:64`. - Risk scan found no runtime, performance, compatibility, SQL dialect, parser-family, shared-path, feature-flag, supply-chain, or operational regression surface. This is consistent with the readability and consistency expectations in `CODE_OF_CONDUCT.md:8` and `CODE_OF_CONDUCT.md:10`. - No unrelated changes were found after matching the local diff boundary against GitHub's file list. ### Verification - Reviewer-run boundary check: `git fetch apache master pull/38773/head:refs/remotes/apache/pr/38773` exited `0`. Git reported an existing local `.git/gc.log` / unreachable-object maintenance warning; it is unrelated to this PR. - Reviewer-run scope check: `git diff --name-status $(git merge-base refs/remotes/apache/master refs/remotes/apache/pr/38773)..refs/remotes/apache/pr/38773` exited `0` and listed only the two MCP configuration docs files. - Reviewer-run stale-pattern check: `if git grep -n '| \`[^\`]* [(][+?][)]\`' refs/remotes/apache/pr/38773 -- docs/document/content/user-manual/shardingsphere-mcp docs/document/content/user-manual; then exit 1; else exit 0; fi` exited `0`, confirming no old inline field-marker rows remain in the reviewed MCP docs scope. - Maven, Spotless, and Checkstyle were not run by the reviewer because this PR only changes Markdown documentation formatting and the review did not modify files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
