tristaZero commented on pull request #5770: URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633365360
Hi @strongduanmu I reviewed your PR, whose core logic is spotless, and tests are enough. I believe you worked hard for it. But I also wonder what you said here. > BTW, I also tried the first solution, and all returned BigInteger types, which would cause many existing unit tests to report errors, so I still prefer the second method. Could you post the exception here? Therefore we can judge whether the fist solution is practical or not. Currently, your PR provides a great implementation of the second one. But actually, the reason why the first solution draws my attention is that it looks so simple and free from any other utils (Not sure). :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
