FlyingZC commented on PR #38776:
URL: https://github.com/apache/shardingsphere/pull/38776#issuecomment-4601091120
Merge Verdict: Mergeable
Reviewed Scope: latest PR head 6a1ac786dfa,
infra/route/core/src/main/java/org/apache/shardingsphere/infra/route/context/RouteContext.java,
infra/route/core/src/main/java/org/apache/
shardingsphere/infra/route/context/RouteUnit.java,
parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/extractor/ColumnExtractor.java.
Not Reviewed Scope: full repo build and full E2E completion were not
waited for in this turn. Need Expert Review: No.
Basis: This PR is a scoped mechanical replacement of Stream API usage with
explicit loops in shared route/parser helper paths. The root cause is direct:
remove stream allocation/collector
overhead from route and column extraction code. The new loops preserve the
same filtering, case-insensitive matching, set/list collection semantics, and
null guards. No SQL parser
grammar, name resolution, routing precedence, config behavior, SPI,
dependency, or public API behavior is changed.
Risk scan: no unrelated file changes in the PR diff; no fallback-only
logic; no silent error swallowing; no new I/O, remote calls, or unbounded
loops. Shared-path blast radius checked for
route users such as sharding/single/readwrite-splitting and parser users
such as binder/encrypt/shadow; the change is behavior-preserving loop expansion.
Pre-merge checks: GitHub Required Check static gates shown passed for
Checkstyle, Spotless, and License. Existing tests already cover the touched
behavior in RouteContextTest,
RouteUnitTest, and ColumnExtractorTest; user confirmed unit tests can
pass. Full CI/E2E should be green before final merge, per CODE_OF_CONDUCT.md
build/check requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
