terrymanu commented on PR #38778: URL: https://github.com/apache/shardingsphere/pull/38778#issuecomment-4602714283
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** PR #38778 latest head `d6a5dcee64b49410851b5b3bb576fe7c7be5b8c1`; base/merge-base `ea0c6f22a5b5bc3c0d296f185a28b55ae54bf709`. Reviewed all 6 files returned by GitHub `/pulls/38778/files`, and the local triple-dot file list matched GitHub exactly: `.github/workflows/e2e-mcp.yml`, `.github/workflows/release-mcp.yml`, `docs/community/content/involved/release/shardingsphere.cn.md`, `docs/community/content/involved/release/shardingsphere.en.md`, `docs/document/content/test-manual/mcp-e2e-test/_index.cn.md`, `docs/document/content/test-manual/mcp-e2e-test/_index.en.md`. - **Not Reviewed Scope:** GitHub Actions run/check status and branch-protection required-status configuration were intentionally not reviewed. - **Need Expert Review:** No. ### Basis - The change fixes the naming root cause directly. `CODE_OF_CONDUCT.md:160` requires workflow names to follow the trigger/operation naming order, and `CODE_OF_CONDUCT.md:163` requires the workflow `name` to match the file name. The PR renames `mcp-e2e.yml` to `e2e-mcp.yml` and updates `name: E2E - MCP` at `.github/workflows/e2e-mcp.yml:18`. - The release workflow is aligned in the same direction: `.github/workflows/release-mcp.yml:18` uses `name: Release - MCP`, and the job key/name/cache suffix were updated consistently at `.github/workflows/release-mcp.yml:50`, `.github/workflows/release-mcp.yml:51`, and `.github/workflows/release-mcp.yml:68`. - The workflow self-reference was updated at `.github/workflows/e2e-mcp.yml:29`, so future edits to the renamed workflow still satisfy its `pull_request.paths` filter. - Documentation references were updated together in both English and Chinese release/test manuals, so the public entry points no longer point to removed workflow files. - Adversarial pass found no unresolved regression path: other E2E workflows keep their existing names, release/schedule/workflow_dispatch triggers are unchanged, and the remaining `mcp-e2e` / `mcp-release` strings are runtime test identifiers or local Docker image tags, not stale workflow file references. ### Verification - Reproduced the PR boundary locally with `git diff refs/remotes/pr/38778/base...refs/remotes/pr/38778/head`. - Cross-checked local changed files against GitHub `/pulls/38778/files`; the lists matched exactly. - Verified the latest PR head has no stale workflow file/name references with `git grep "mcp-e2e.yml\|mcp-release.yml\|MCP - E2E\|MCP - Release" refs/remotes/pr/38778/head`. - Parsed both renamed workflow YAML files from the PR head with Ruby YAML successfully. - Ran `git diff --check refs/remotes/pr/38778/base...refs/remotes/pr/38778/head`; no whitespace or patch-format issues were reported. - No Maven tests were run because this PR only renames GitHub workflow/docs references and does not touch production or test code paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
