terrymanu commented on PR #38790:
URL: https://github.com/apache/shardingsphere/pull/38790#issuecomment-4611538418
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** PR #38790 latest head
`2478e3fe1b1236fe91211f7d1b7f64164cbb0733`; base
`9bf847a50a4c2425f05de20662f2fb39d5c6e27a`; local merge-base
`9bf847a50a4c2425f05de20662f2fb39d5c6e27a`. Reviewed
`.github/workflows/jdk21-subchain-ci.yml` renamed to
`.github/workflows/ci-mcp.yml`. GitHub `/pulls/38790/files` matched the local
triple-dot diff exactly: one renamed workflow file.
- **Not Reviewed Scope:** Java production/test code, MCP runtime behavior,
GitHub Actions/check-run status, and any external branch-protection
required-check settings not stored in the repository.
- **Need Expert Review:** No dedicated domain expert review required.
### Basis
- The PR directly addresses the naming issue by changing the workflow file
from `jdk21-subchain-ci.yml` to `ci-mcp.yml`, aligning it with the existing
operation-domain pattern used by `.github/workflows/e2e-mcp.yml` and
`.github/workflows/release-mcp.yml`.
- The workflow display name is now `CI - MCP`, which matches the new file
name and avoids implying that this is a generic JDK 21 subchain job.
- The self-trigger path was updated to `.github/workflows/ci-mcp.yml`, so
future edits to this workflow still trigger the workflow as expected.
- The concurrency group was updated from `jdk21-subchain-ci-*` to
`ci-mcp-*`, keeping it consistent with the renamed workflow while preserving
the same cancellation behavior.
- The job display name now says `MCP - Unit Tests with JDK 21`, which keeps
the actual scope visible without changing the job id, runner, timeout, cache
suffix, Maven module list, or Maven command.
- No substantive unrelated changes were found.
### Verification
- PR scope boundary was validated with GitHub `/pulls/38790/files` and local
`git diff <merge-base>..refs/remotes/apache/pr/38790`.
- Local diff showed only:
- `R091 .github/workflows/jdk21-subchain-ci.yml ->
.github/workflows/ci-mcp.yml`
- 4 insertions and 4 deletions, all naming/self-reference changes.
- Reviewer-run local checks:
- `./mvnw spotless:check -Pcheck -T1C`: passed, exit 0
- `./mvnw checkstyle:check -Pcheck -T1C`: passed, exit 0
- GitHub Actions/check-run status was intentionally not used for this merge
decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
