FlyingZC commented on PR #38792:
URL: https://github.com/apache/shardingsphere/pull/38792#issuecomment-4618282733
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** PR #38792 latest head
`ad07bd56d74cb03fd16a88bd2c1a88ff599b5fa7`; merge-base
`25427fab94c911f6245f9d5ac2554710c08bb46c`. Reviewed
`parser/sql/statement/core/src/
main/java/org/apache/shardingsphere/sql/parser/statement/core/extractor/ColumnExtractor.java`;
local triple-dot file list matches GitHub `/pulls/38792/files`.
- **Not Reviewed Scope:** Full repository build, benchmark/JFR validation,
GitHub Actions/check-runs, and downstream Proxy/JDBC end-to-end smoke tests.
- **Need Expert Review:** No.
### Basis
- The change is scoped to `ColumnExtractor` and reduces recursive
intermediate collection allocation by reusing the caller-provided accumulator.
- The touched path is shared by sharding route condition extraction,
encrypt rewrite, shadow route retrieval, binder returned-column inference, and
Oracle visitor extraction. The reviewed
change does not add new lookup order, schema resolution, routing
precedence, parser grammar, SQL syntax, API/SPI, config, or feature-flag
behavior.
- The early-return structure is safe for the checked expression segment
types in this method: `FunctionSegment`, XML function segments, aggregation
projection, row/list/in/between/binary/
case/not/unary/collate segments are distinct concrete paths for this
extractor.
- No direct `ConcurrentHashMap#computeIfAbsent` use is introduced on the
Proxy/JDBC high-frequency SQL path.
- No unrelated files are included in the PR scope.
### Verification
- Local reviewer verification was run on the PR head with dependent
modules included:
- `./mvnw -pl parser/sql/statement/core -am -DskipITs
-Dspotless.skip=true -Dtest=ColumnExtractorTest
-Dsurefire.failIfNoSpecifiedTests=false test`
- Result: `BUILD SUCCESS`; `ColumnExtractorTest` ran 18 tests with 0
failures, 0 errors, 0 skipped.
- GitHub Actions / CI status was not used for this merge verdict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
