terrymanu commented on PR #38799:
URL: https://github.com/apache/shardingsphere/pull/38799#issuecomment-4619707745
### Decision
- **Merge Verdict: Mergeable**
- Reviewed Scope: latest PR head `c6850d5758c26dab590bcd445a205bfb741b5257`,
merge base `56e7caf32956fbdd3af50ad21fa02a75d2e1c126`; GitHub
`/pulls/38799/files` and local triple-dot diff both contain only:
-
`docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.cn.md`
-
`docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.en.md`
- Not Reviewed Scope: GitHub Actions, CI status, and check-runs were not
used for this verdict. No production or test code is changed.
- Need Expert Review: None.
### Basis
No blocking issues found.
The troubleshooting update is consistent with current MCP launch validation:
`runtimeDatabases` is required and non-empty in `YamlMCPLaunchConfiguration`,
so documenting startup failure for missing or empty runtime databases is
accurate.
The PR also removes the misleading implication that invisible databases can
be caused by an entirely missing `runtimeDatabases` at runtime. That is now
correctly treated as a startup configuration problem, while visibility issues
focus on wrong names, failed connections, privileges, or empty scope.
The new follow-up rows are framed as future code improvements, not current
behavior. I cross-checked the current tool name, runtime status category list,
HTTP security handling, query error conversion, and metadata visibility
handling; the document does not claim those future categories or names already
exist.
Chinese and English documents are synchronized, and the change stays within
the stated MCP troubleshooting documentation scope.
### Verification
- `curl https://api.github.com/repos/apache/shardingsphere/pulls/38799` -
passed.
- `curl
https://api.github.com/repos/apache/shardingsphere/pulls/38799/files?per_page=100`
- passed.
- `git diff --name-status $(git merge-base apache/master
origin/pr/38799)..origin/pr/38799` - passed; matched GitHub file list.
- `git diff --check $(git merge-base apache/master
origin/pr/38799)..origin/pr/38799 --
docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.cn.md
docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.en.md` -
passed.
- `./mvnw spotless:check -Pcheck -T1C` - passed.
- Unit tests were not run because this PR only changes Markdown
documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
