terrymanu commented on PR #38801:
URL: https://github.com/apache/shardingsphere/pull/38801#issuecomment-4619769648
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** PR #38801 latest head
`463fde979f2f4154eb8ab6df647c972a738fa8ed`; base ref `apache/master` at
`8d472d5cae903c923a8f56a9b410888c02eaed83`; local merge-base
`8d472d5cae903c923a8f56a9b410888c02eaed83`. GitHub `/pulls/38801/files` matched
the local triple-dot file list. Reviewed the single changed file
`RELEASE-NOTES.md:22`, the surrounding 5.5.4 release-note style, and the merged
#38645 change summarized by this entry.
- **Not Reviewed Scope:** Runtime behavior of #38645 itself, full Maven
suite, CI/check-runs, and unrelated release-note entries.
- **Need Expert Review:** No.
### Basis
- The PR fixes the release-note gap for #38645 with one focused entry under
`Release 5.5.4` / `Bug Fixes`.
- The wording is accurate for the merged #38645 behavior: PostgreSQL Proxy
backend `client_encoding` is forced/normalized to UTF8 and non-UTF8 values are
rejected to stay consistent with pgjdbc parameter encoding.
- The entry placement is consistent with nearby Proxy bug-fix entries and
does not introduce unrelated documentation churn.
- The line length is 196 characters, which stays within the repository
coding standard in `CODE_OF_CONDUCT.md:28`.
- No parser, shared execution path, dependency, API/SPI, config, or runtime
code is touched, so no SQL dialect-family or blast-radius review is required.
### Verification
- `git fetch apache +refs/heads/master:refs/remotes/apache/master
+refs/pull/38801/head:refs/remotes/apache/pr-38801` exited `0`.
- `git diff --name-status
refs/remotes/apache/master...refs/remotes/apache/pr-38801` exited `0` and
showed only `RELEASE-NOTES.md`.
- GitHub `/pulls/38801/files` showed the same single changed file.
- `git diff --check
refs/remotes/apache/master...refs/remotes/apache/pr-38801` exited `0`.
- `git show refs/remotes/apache/pr-38801:RELEASE-NOTES.md | awk 'NR==22
{print length($0)}'` exited `0` and returned `196`.
- Maven tests, Spotless, and Checkstyle were not run because this PR only
adds one release-note line and changes no production, test, parser, or
configuration code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
