terrymanu commented on PR #38803: URL: https://github.com/apache/shardingsphere/pull/38803#issuecomment-4620427831
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** PR #38803 latest head `0e3323f4edb563a70c90a64c33ea5da466cd3938`; base `408cfae25cbf758a2a00ca678d492b5687112774`; local merge-base `408cfae25cbf758a2a00ca678d492b5687112774`. Reviewed `.asf.yaml` only. GitHub `/pulls/38803/files` matched the local triple-dot file list exactly. - **Not Reviewed Scope:** GitHub Actions/check-run status, live branch-protection state after ASF synchronization, and runtime Java modules because this PR only changes repository governance YAML. - **Need Expert Review:** No additional code-domain expert review required; project governance/Infra confirmation can be handled through normal maintainer approval. ### Basis - **Root-cause fix:** The three required checks are configured as branch-protection contexts in `.asf.yaml:49`. The PR changes `contexts` to an empty list at `.asf.yaml:50` and keeps the previous `Check - CheckStyle`, `Check - Spotless`, and `Check - License` entries as comments with the stated temporary runner-capacity reason. - **Config semantics:** ASF `.asf.yaml` branch-protection documentation and GitHub branch-protection documentation both treat `contexts` as the required status-check list. With `contexts: []`, these three checks are no longer configured as required status contexts. - **Ordinary check behavior preserved:** `.github/workflows/required-check.yml` still defines `Check - CheckStyle`, `Check - Spotless`, and `Check - License`, so the PR does not stop those workflow jobs from running as ordinary PR checks. - **Adjacent protection preserved:** `required_pull_request_reviews` remains unchanged with `dismiss_stale_reviews: true` and `required_approving_review_count: 1`. - **Risk scan:** No shared execution path, parser behavior, SQL compatibility, runtime config, API/SPI, dependency, or high-frequency Proxy/JDBC path is touched. No substantive unrelated changes were found. ### Verification - Fetched latest base and PR refs, then compared GitHub `/pulls/38803/files` with local `git diff --name-status 408cfae25cbf758a2a00ca678d492b5687112774..0e3323f4edb563a70c90a64c33ea5da466cd3938`; both list only `.asf.yaml`. - Parsed the PR-head `.asf.yaml` with Ruby YAML loading and verified `github.protected_branches.master.required_status_checks.contexts == []`. - Verified `required_pull_request_reviews` values are preserved at PR head. - Verified the three workflow job names remain present in `.github/workflows/required-check.yml`. - Did not use GitHub Actions or CI status for this merge decision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
