terrymanu commented on PR #38814: URL: https://github.com/apache/shardingsphere/pull/38814#issuecomment-4632169233
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** PR `#38814` latest head `9d57a1c881d88687ba5c3a50091585bf0351b74e`, local merge-base `709596fea5e2e836c1f3eae49789042d5078dd07`; GitHub `/pulls/38814/files` count `1` matched the local triple-dot diff. Reviewed `RELEASE-NOTES.md:28`, PR body `For #38806`, linked implementation PR `#38806`, and linked bug issue `#38805`. - **Not Reviewed Scope:** GitHub Actions/check-runs, full local Maven build, runtime JDBC/Proxy E2E, and production/test code outside the release-note target. - **Need Expert Review:** No specialized security, parser, protocol, concurrency, or performance review required. ### Basis - The PR is scoped to one release-note entry under `Release 5.5.4` / `Bug Fixes`, and the local file list matches GitHub's authoritative Files Changed boundary. - The entry accurately summarizes the user-visible fix from merged PR `#38806`: `AUTO_INTERVAL` sharding no longer fails when the JVM default locale uses comma decimal separators. - The referenced issue `#38805` reports the same symptom and affected scope: `AutoIntervalShardingAlgorithm` in sharding core, affecting both JDBC and Proxy. - No production code, parser behavior, SQL syntax, routing precedence, config/API/SPI contract, dependency manifest, implicit state, or high-frequency execution path is changed by this PR. - No substantive unrelated changes were found. ### Verification - `git diff --name-status refs/remotes/apache/master...refs/remotes/pr/38814` returned only `RELEASE-NOTES.md`. - `git diff refs/remotes/apache/master...refs/remotes/pr/38814 -- RELEASE-NOTES.md` showed one added release-note line. - `git show refs/remotes/pr/38814:RELEASE-NOTES.md` confirmed the entry is placed in `Release 5.5.4` / `Bug Fixes` at `RELEASE-NOTES.md:28`. - GitHub metadata confirms PR `#38806` is merged and belongs to milestone `5.5.4`. - No Maven tests or style gates were run because this PR is release-note-only and does not modify production, test, configuration, or parser files. - No GitHub Actions / CI status was used for this review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
