terrymanu commented on PR #38817: URL: https://github.com/apache/shardingsphere/pull/38817#issuecomment-4633090337
### Summary - **Merge Decision: Mergeable** - **Reason:** The PR directly adds portable-path guidance and a handoff check in `AGENTS.md` without touching runtime code, parser behavior, shared execution paths, or unrelated scope. ### Evidence - `AGENTS.md:108` adds a clear `Path portability` rule that forbids hard-coded local machine paths and workspace-specific absolute paths when writing code, tests, scripts, or skills. - `AGENTS.md:109` gives portable alternatives: repository-relative paths, configurable parameters, temporary directories, or documented environment variables. - `AGENTS.md:144` adds a handoff check so agents verify code and skills do not contain local machine paths before completion. - The PR scope is limited to `AGENTS.md` with 3 inserted lines; no production code, test code, parser grammar, runtime config, dependency, or shared execution path changed. - No concrete local absolute path examples were introduced; `git grep` for common absolute-path forms returned no matches in `AGENTS.md`. - No linked issue claim, previous review comment, or substantive unrelated change was found in the reviewed PR metadata. ### Review Details - **Reviewed Scope:** PR `apache/shardingsphere#38817`, `AGENTS.md`; latest PR head `5a65c022d13ce5aaf0a3d4de35fe2ccad59ca157`; local merge-base `619bdce9113c7b7915cbd2c1c3b0d7d367f2f57e`; local file list matched GitHub `/pulls/38817/files` (`M AGENTS.md`). - **Not Reviewed Scope:** GitHub Actions/check-runs were intentionally not used; runtime modules, SQL parser behavior, JDBC/Proxy execution, and unit tests were not reviewed beyond confirming they are not touched by this docs-only PR. - **Verification:** `git fetch --no-tags apache master:refs/remotes/apache/master pull/38817/head:refs/remotes/apache/pr/38817` exit 0; `git diff --name-status refs/remotes/apache/master...refs/remotes/apache/pr/38817` exit 0; `git grep -n -E '(/Users/|/home/|[A-Za-z]:\\|file://)' refs/remotes/apache/pr/38817 -- AGENTS.md` exit 1, expected no matches; `./mvnw spotless:check -Pcheck -T1C` exit 0; `./mvnw checkstyle:check -Pcheck -T1C` exit 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
