terrymanu commented on PR #38820: URL: https://github.com/apache/shardingsphere/pull/38820#issuecomment-4637427460
### Summary - **Merge Decision: Mergeable** - **Reason:** This is a scoped AI-agent rule clarification that aligns with the repository Javadoc standard and does not change production, test, parser, or runtime behavior. ### Evidence - The PR changes only `AGENTS.md:31`, adding guidance for redundant Javadocs on overridden methods; the GitHub file list and local triple-dot diff both show 1 file changed with 5 added lines. - The new rule is consistent with `CODE_OF_CONDUCT.md:78`, especially the existing statement that user-facing API/SPI Javadocs should be clear while methods overriding parent classes do not need Javadoc. - The rule keeps the public contract on the declaring API, SPI, or interface and explicitly preserves exception cases for implementation-specific behavior, stricter preconditions, side effects, exceptions, compatibility notes, or semantics not covered by the parent declaration. - No runtime code, SQL parser grammar/visitor/tests, shared execution path, API/SPI signature, configuration, dependency, or high-frequency path is touched, so there is no behavior, compatibility, performance, supply-chain, or dialect-family regression surface from this PR. - No substantive unrelated changes were found, and there were no GitHub-visible prior review comments or review threads requiring multi-round comparison. ### Review Details - **Reviewed Scope:** Latest PR head `b3b60b831541ca33ab31b0b4ffbd0326cc148818`, base and local merge-base `6e3bb9f6e34e99a217eb32b7337d2f6080b4be68`; reviewed `AGENTS.md`; local `git diff --name-status 6e3bb9f6e34e99a217eb32b7337d2f6080b4be68..apache/pr/38820` matched GitHub `/pulls/38820/files`. - **Not Reviewed Scope:** GitHub Actions/check-run status was intentionally not reviewed; unit/runtime tests were not run because this is a documentation-only AI-agent guidance change with no executable code. - **Verification:** `./mvnw spotless:check checkstyle:check -Pcheck -T1C` exited 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
