terrymanu commented on PR #38821: URL: https://github.com/apache/shardingsphere/pull/38821#issuecomment-4637638997
### Summary - **Merge Decision: Mergeable** - **Reason:** This is a scoped release-note-only update, and the added entry accurately reflects the merged JDBC/MySQL fix in [#38444](https://github.com/apache/shardingsphere/pull/38444). ### Evidence - `RELEASE-NOTES.md:17` adds one 5.5.4 JDBC bug-fix entry for `ResultSet#getObject(index, Class<T>)` and links to [#38444](https://github.com/apache/shardingsphere/pull/38444). - [#38444](https://github.com/apache/shardingsphere/pull/38444) is a merged JDBC/MySQL bug fix titled `jdbc: add MySQL-compatible typed string conversion`, and its PR body notes the missing release-note update. - The current PR changes only `RELEASE-NOTES.md`; there are no production, test, parser, or runtime behavior changes. - The release-note wording matches the linked change scope: MySQL-compatible JDBC typed string conversion while preserving strict non-MySQL behavior. ### Review Details - **Reviewed Scope:** Latest PR head `6a127906e8f18939008e104e5447f89150c258c3`; local merge-base `42402f2a351e4a1edd9ffd16780897f89c64b777`; local triple-dot file list matched GitHub `/pulls/38821/files` with one modified file: `RELEASE-NOTES.md`. - **Not Reviewed Scope:** GitHub Actions/check-runs were not reviewed. Maven tests were not run because this PR is release-note-only and does not change code or generated artifacts. - **Verification:** GitHub API checks for PR #38821 and linked PR #38444 exited 0; `git fetch apache master:refs/remotes/apache/master pull/38821/head:refs/remotes/apache/pr/38821` exited 0; `git diff --name-status $(git merge-base refs/remotes/apache/master refs/remotes/apache/pr/38821)..refs/remotes/apache/pr/38821` exited 0 and showed only `M RELEASE-NOTES.md`. ### Issues No blocking issues found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
