terrymanu commented on PR #38837: URL: https://github.com/apache/shardingsphere/pull/38837#issuecomment-4662150162
### Summary - **Merge Decision: Mergeable** - **Reason:** The PR directly removes the conflicting AI-agent guidance and aligns `AGENTS.md` with the higher-priority local-variable rule in `CODE_OF_CONDUCT.md`. ### Evidence - `AGENTS.md:13` already declares `CODE_OF_CONDUCT.md` as the binding rule source for coding standards. - `CODE_OF_CONDUCT.md:54` says local variables should not be set as `final`. - The PR updates both conflicting AI-agent instructions in `AGENTS.md:36` and `AGENTS.md:148` to keep variable declarations near first use without marking local variables `final`. - `src/resources/checkstyle.xml:151` still enforces `VariableDeclarationUsageDistance`; the new wording preserves that intent by requiring declarations near first use instead of using `final` as a workaround. - Scope, regression, and ownership checks are clean: this is a one-file AI guidance change, with no runtime code, SQL parser, shared execution path, dependency, packaging, or release artifact impact. - The original symptom path is covered by the diff: a grep on the latest PR head no longer finds the old "declare it `final`" / "mark retained values `final`" guidance in `AGENTS.md`. ### Review Details - **Reviewed Scope:** PR #38837 latest head `651e37618d2070c3ab6006d643be8db9ffda464b`; base `master` at `c22b9997437800901569b0bc2702e0964530edc6`; local merge-base `c22b9997437800901569b0bc2702e0964530edc6`. GitHub `/pulls/38837/files` reports `AGENTS.md` only, and local triple-dot diff matched it. - **Not Reviewed Scope:** GitHub Actions / CI status was intentionally not reviewed. Runtime modules, SQL dialect/parser behavior, dependencies, distribution packaging, and end-user docs were not deeply reviewed because they are not touched by this PR. - **Verification:** `git fetch apache master:refs/remotes/apache/master pull/38837/head:refs/remotes/apache/pr/38837` exit 0; `git diff --name-status refs/remotes/apache/master...refs/remotes/apache/pr/38837` exit 0; `git grep` for the removed final-local guidance on the PR head exit 0; `./mvnw spotless:check -Pcheck -T1C` exit 0; `./mvnw checkstyle:check -Pcheck -T1C` exit 0. - **Release Note / User Docs:** Not required; this only corrects internal AI-agent development guidance and does not change user-visible behavior, configuration, APIs, SQL support, diagnostics, or released artifacts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
