strongduanmu commented on PR #38841:
URL: https://github.com/apache/shardingsphere/pull/38841#issuecomment-4676680887
### Summary
- **Merge Decision: Mergeable**
- **Reason:** The refactor fixes the parameter parsing path for values
containing colons, and the changed E2E configuration does not show a concrete
regression risk in the current scope.
### Evidence
- `SQLE2ETestCaseAssertion#getSQLValues()` now parses each parameter by
the last colon, which fits existing E2E parameter values such as
`12:30:30:time` and timestamp values containing colons.
- SQL E2E has passed, so the changed parsing path is covered through the
actual E2E prepared-statement usage path.
- The added MySQL `plugin_dir` setting is limited to E2E container
configuration, and there is no plugin installation/loading path in this PR, so
no concrete runtime behavior regression is identified for the reviewed scope.
- No substantive production code, public API/SPI, parser grammar,
dependency, packaging, release note, or user documentation impact was found.
### Review Details
- **Reviewed Scope:** PR #38841 latest head
`0bc15db637db17918bc0c03139e61e3a58e19afb`; 5 changed files under SQL E2E
assertion parsing and MySQL E2E container configs.
- **Not Reviewed Scope:** Full local Maven/E2E execution was not rerun in
this review.
- **Verification:** Reviewed PR diff and GitHub file list; user confirmed
CI E2E has passed.
- **Release Note / User Docs:** Not required, because this is test
framework / E2E resource maintenance with no user-facing product behavior
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
