sandynz commented on PR #38842:
URL: https://github.com/apache/shardingsphere/pull/38842#issuecomment-4680784528
### Summary
- **Merge Decision: Mergeable**
- **Reason:** The change is limited to agent-facing high-output command
handling rules, and the latest diff closes the read-only gap by requiring
command classification plus the canonical wrapper before high-output
shell execution.
### Evidence
- `AGENTS.md:3` now keeps the high-output command rule as a first-action
gate, and `AGENTS.md:9` explicitly routes execution through the `Mandatory
Execution Contract` in `.codex/context/high-output-commands.md`.
- `.codex/context/high-output-commands.md:11` adds the mandatory contract,
and `.codex/context/high-output-commands.md:15` requires classifying a command
before emitting it.
- `.codex/context/high-output-commands.md:17` to
`.codex/context/high-output-commands.md:23` defines `Must Wrap`, `May Run Raw`,
and `Unsure`, including the rule to rewrite raw commands that should be wrapped.
- `.codex/context/high-output-commands.md:65` to
`.codex/context/high-output-commands.md:87` centralizes the shell wrapper,
preserves the real exit code via `rc=$?`, avoids `status=$?`, and limits
failure output to
a bounded `tail -n 30`.
- `.codex/context/high-output-commands.md:99` to
`.codex/context/high-output-commands.md:107` handles IDE/MCP runs separately,
so tool-managed runs are not incorrectly forced through shell redirection.
- `.codex/context/high-output-commands.md:116` to
`.codex/context/high-output-commands.md:125` narrows database-client wrapping
to potentially large query/metadata/diagnostic output while keeping small
version/help
checks raw.
- Scope and ownership are appropriate: the diff only changes `AGENTS.md`
and `.codex/context/high-output-commands.md`, with no production code, public
API, runtime behavior, dependency, packaging, parser, or SQL
semantics changes.
- ASF/license risk is covered by repository configuration: Markdown files
are excluded by `src/resources/rat.txt`, and `apache-rat:check` passes on the
reviewed head.
- No release note or user documentation is required because the change
affects AI-agent workflow guidance only and does not change released
ShardingSphere behavior.
### Review Details
- **Reviewed Scope:** Local commit range
`96090bd0c1ecc488d80d85b1a052344b04bbf608..e48e5ffed8efe852346773ea7fbc9bbf871152fc`;
latest reviewed head `e48e5ffed8efe852346773ea7fbc9bbf871152fc`; reviewed
files:
`AGENTS.md`, `.codex/context/high-output-commands.md`. GitHub
`/pulls/{number}/files` matching was not checked because this review was
requested for a local commit range rather than a GitHub PR number.
- **Not Reviewed Scope:** GitHub Actions/check-run status, PR metadata,
and unrelated repository files outside the two-file local diff.
- **Verification:** `git diff --check -- AGENTS.md
.codex/context/high-output-commands.md` exit 0; `./mvnw apache-rat:check
-Pcheck -T1C` exit 0 with temporary local log
`shardingsphere-verify.XXXXXX.log`; `./mvnw
spotless:check -Pcheck -T1C` exit 0 with temporary local log
`shardingsphere-verify.XXXXXX.log`; `./mvnw checkstyle:check -Pcheck -T1C` exit
0 with temporary local log `shardingsphere-verify.XXXXXX.log`.
- **Release Note / User Docs:** Not required; this is internal agent
workflow documentation and has no user-facing product behavior, configuration,
SQL support, migration, diagnostics, or distribution impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
