menghaoranss commented on PR #38843: URL: https://github.com/apache/shardingsphere/pull/38843#issuecomment-4686699365
### Summary - **Merge Decision: Mergeable** - The PR fixes the shared default schema naming path so schema-unavailable databases no longer force dialect upper/lower-case formatting for the in-memory default schema name. - The Oracle provider now makes schema lookup case-insensitive while preserving Oracle table lookup as upper-case, which matches the intended metadata shape: logical schema name stays as `databaseName`, while physical table names still follow storage rules. ### Review Details The latest change keeps the fix at the right ownership boundary: - `DatabaseTypeRegistry#getDefaultSchemaName(...)` now returns the original `databaseName` when `DialectSchemaOption#isSchemaAvailable()` is `false` and no fixed default schema exists. - Oracle adds a dialect-owned schema rule override through `OracleIdentifierCaseRuleProvider`, so `IdentifierScope.SCHEMA` becomes insensitive for Oracle without changing table lookup behavior. - PostgreSQL/openGauss and fixed-default-schema dialects such as SQLServer/Hive/Presto keep their existing default schema behavior. - MySQL already has schema-scope insensitive handling through its provider. One follow-up remains: Firebird has the same schema-unavailable/default-uppercase shape, but it does not currently have a dedicated identifier-case provider. Since Firebird is not part of the active usage scope for this PR, I am not blocking this PR on that dialect, but it should be handled in a follow-up PR to avoid leaving the same schema lookup split there. ### Verification Reviewed the PR diff and identifier metadata chain for: - default schema name generation - Oracle schema/table identifier rules - shared `DatabaseIdentifierContextFactory` schema-scope behavior - adjacent schema-unavailable dialect impact - updated tests and binder expected metadata changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
