terrymanu commented on PR #38856: URL: https://github.com/apache/shardingsphere/pull/38856#issuecomment-4723095280
### Summary - **Merge Decision: Mergeable** - **Reason:** The PR is a scoped bilingual documentation cleanup that removes one resolved follow-up item while preserving the documented MCP startup requirement. ### Evidence - The reviewed diff only changes `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.en.md` and `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.cn.md`, removing the `runtimeDatabases` startup-policy row from the future improvement table. - The remaining troubleshooting docs still tell users that `runtimeDatabases` is required at startup and must contain at least one runtime database (`docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.en.md:15`, `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.en.md:29`, `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.cn.md:15`, `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.cn.md:29`). - The current MCP YAML contract is consistent with that documentation: `runtimeDatabases` is annotated with `@NotEmpty` (`mcp/bootstrap/src/main/java/org/apache/shardingsphere/mcp/bootstrap/config/yaml/config/YamlMCPLaunchConfiguration.java:43`), and existing tests cover missing and empty runtime databases (`mcp/bootstrap/src/test/java/org/apache/shardingsphere/mcp/bootstrap/config/MCPLaunchConfigurationTest.java:65`, `mcp/bootstrap/src/test/java/org/apache/shardingsphere/mcp/bootstrap/config/yaml/swapper/YamlMCPLaunchConfigurationSwapperTest.java:120`). - Scope and ownership are clean: no production code, parser, SQL semantics, dependency, packaging, API/SPI, default-schema, routing, or shared execution-path behavior is changed. - The linked issue `#35294` is a broad MCP idea tracker and remains open; this PR says `For #35294` but does not claim to close or fully resolve it, so the narrower documentation cleanup does not over-claim issue completeness. - No additional tests are required for this docs-only row removal; existing runtime/config tests provide consistency evidence for the documented startup policy. ### Review Details - **Reviewed Scope:** PR `#38856`, latest head SHA `44a899ba40324b04f0736935e1a83b31bfb6a7e3`, base ref `master`, local merge-base SHA `f40fd90435ac28ce6eca996ebe7c29cbb3973673`; reviewed files were `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.en.md` and `docs/document/content/user-manual/shardingsphere-mcp/troubleshooting.cn.md`. The local triple-dot file list matched GitHub `/pulls/38856/files`. - **Not Reviewed Scope:** CI/check-run status, full documentation-site rendering, and runtime MCP startup execution were not reviewed; they are not needed to decide merge safety for this Markdown-only cleanup. - **Verification:** `git fetch --quiet apache +refs/heads/master:refs/remotes/apache/master +refs/pull/38856/head:refs/remotes/apache/pr/38856` exited `0`; `git diff --name-status <merge-base>..refs/remotes/apache/pr/38856` exited `0` and matched the GitHub file list; targeted `git diff`, `git show`, and `git grep` inspections exited `0`. Maven was not run because no production code, tests, build files, or generated artifacts changed. - **Release Note / User Docs:** This PR itself updates user documentation. A `RELEASE-NOTES.md` entry is not required because there is no released behavior, configuration, API/SPI, migration, or runtime compatibility change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
