linghengqian commented on code in PR #2513:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2513#discussion_r3426705698
##########
kernel/src/test/java/org/apache/shardingsphere/elasticjob/kernel/executor/facade/SingleShardingJobFacadeTest.java:
##########
@@ -194,10 +193,10 @@ void assertRegisterJobCompletedWhenRunningOnOtherHost() {
jobInstance2.setServerIp("192.168.1.3");
availJobInst.add(jobInstance2);
when(instanceService.getAvailableJobInstances()).thenReturn(availJobInst);
-
- singleShardingJobFacade.registerJobCompleted(shardingContexts);
-
Review Comment:
> Build and tests passed successfully. Regarding Checkstyle, the violations
exist in the original codebase and are not introduced by this PR. I previously
tried running `spotless:apply` but it reformatted ~2000 lines unrelated to this
fix, so I left it as is to keep the diff clean.
This is not a bug in the master branch, but rather that the changes you
introduced were not formatted.
Considering you don't have a Linux environment, and I can't find a Windows
environment to test in the short term, I really don't know how to explain it to
you.
I personally believe a separate PR is needed to fix checkstyle on Windows,
which would require modifying the project's git configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
