014-code commented on PR #38835:
URL: https://github.com/apache/shardingsphere/pull/38835#issuecomment-4741282539
Thanks for the detailed review.
I have updated the implementation to preserve the variable semantics in the
parsed statement model instead of inferring them from the rendered variable
name.
Changes made:
- Added VariableType to VariableSegment, with SYSTEM as the default type.
- Updated the MySQL SET visitor to mark user variables as USER and internal
variable names as INTERNAL.
- Updated MySQLSetVariableAdminExecutor to skip system-variable validation
based on VariableType.USER instead of startsWith("@").
- Added regression coverage for SET @test_var = 1 and SET @test_var := 1.
- Kept coverage for unknown SESSION variables and valid GLOBAL variables.
Verification:
- MySQLSetVariableAdminExecutorTest passed.
- Spotless passed.
- Checkstyle passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
