zhaojinchao95 commented on PR #38883:
URL: https://github.com/apache/shardingsphere/pull/38883#issuecomment-4766208319
Conclusion: Mergeable, assuming your local CI passes before merging.
### Summary
Review Result: Mergeable
Reason: The latest PR head 862270082427b40dd1b71369b7a8c87cc8ea3023
includes the requested fix and the Spotless formatting update. The Proxy SQL
CREATE DATABASE path now calls DatabaseNameValidator.validate(...) before
creating metadata, and the invalid
database-name test has been added.
### Evidence
- CreateDatabaseProxyBackendHandler.java:42 now calls:
DatabaseNameValidator.validate(sqlStatement.getDatabaseName());
- CreateDatabaseProxyBackendHandlerTest.java:50-55 covers the invalid
foo-db database-name scenario.
- The local worktree is clean.
- The previous Spotless formatting diff for the test file is gone, so the
formatting commit is included in the latest PR head.
### Review Details
- Reviewed head: 862270082427b40dd1b71369b7a8c87cc8ea3023
- Base: 534e7f8eab7e6bfcd3159928cca4386440948c55
- Merge-base: 920b9f7ac740978ce8d1c7a4ec59cf1757026c7b
- Not reviewed: Maven/CI was not rerun in this round, per your note that
you will run CI locally.
- Remaining risk: CI result only. From code review, I did not find any new
merge-blocking issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
