terrymanu commented on PR #38887: URL: https://github.com/apache/shardingsphere/pull/38887#issuecomment-4770774791
### Summary **Review Result: Mergeable** Current implementation looks good to me. The PR refines `IndexReviser` to accept index-name recovery candidates, and the updated Sharding/Encrypt implementations and tests are aligned with the new contract. CI is green. ### Non-blocking Suggestions - The new parameter name `indexNameRecoveryCandidateTableMetaDataList` is clearer in `IndexReviser` and implementations. If we want to make the contract easier to follow end-to-end, we can consider aligning the same naming in the upstream pass-through variables in `IndexReviseEngine`, `TableMetaDataReviseEngine`, and `SchemaMetaDataReviseEngine` as a follow-up. - `CreateTablePushDownMetaDataRefresherTest` now covers the create-table candidate path for restoring truncated named indexes, which is the key regression path for this change. ### Review Details - Reviewed latest PR head: `b63d1cd7c46525ce0652a4dab65fd86ec941743b` - Reviewed scope: `IndexReviser`, Sharding/Encrypt index revisers, schema builder material, standalone rebuild path, and related tests. - Verification: GitHub checks are green: 87/87 check-runs succeeded. - Release Note / User Docs: Not required for this PR, since this is an internal metadata revision contract refinement and does not introduce user-facing configuration or behavior changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
