terrymanu commented on PR #38892: URL: https://github.com/apache/shardingsphere/pull/38892#issuecomment-4771659635
### Summary **Review Result: Mergeable** Reason: The PR is a small behavior-preserving refactor of `CreateTablePushDownMetaDataRefresher`. The changed `createRevisionCandidateIndexes` flow keeps the same semantics for absent index names, index columns, index name recovery, and unique-key calculation, while making the Optional handling easier to read. ### Evidence - `mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/table/CreateTablePushDownMetaDataRefresher.java:69` still skips constraint definitions without an index name. - `mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/table/CreateTablePushDownMetaDataRefresher.java:75` reuses the same `IndexSegment` values that the previous `Optional#ifPresent` lambda used. - `mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/table/CreateTablePushDownMetaDataRefresherTest.java` already covers both the normal create-table refresh path and the sharding truncated named-index restoration path related to #38449. - Public PR checks for Spotless and Checkstyle are successful, and no completed failing check run was found at review time. ### Review Details - Reviewed Scope: PR #38892 latest head `2c50381b5695e741c9d86164011db0e735ffc4d1`, base/merge-base `643f40f69f8abd05bf9eccb06a9efceee5d9946d`; GitHub changed-file list matched local triple-dot scope. Reviewed `mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/table/CreateTablePushDownMetaDataRefresher.java`. - Not Reviewed Scope: Full repository build and broader E2E jobs; they are not required for this single-file internal refactor review. - Verification: `./mvnw -pl mode/core -DskipTests -Dspotless.skip=true checkstyle:check -Pcheck -T1C` passed. `./mvnw -pl mode/core -am -DskipITs -Dspotless.skip=true -Dtest=CreateTablePushDownMetaDataRefresherTest -Dsurefire.failIfNoSpecifiedTests=false test` passed. - Release Note / User Docs: Not required; this is an internal readability refactor with no user-facing behavior, API, configuration, dependency, or distribution change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
