iamhucong opened a new pull request, #38897:
URL: https://github.com/apache/shardingsphere/pull/38897

   ### Motivation
   
   `TemporalLiteralExpressionSegment` keeps the raw literal value for consumers 
while preserving the original SQL literal text, such as `DATE '2017-08-08'`, 
through `getText()`.
   
   `InsertValue` renders insert value expressions back to SQL. Since 
`TemporalLiteralExpressionSegment` extends `LiteralExpressionSegment`, it could 
otherwise fall through the generic literal formatter and render a date literal 
as a plain string literal.
   
   ### Changes
   
   - Return `TemporalLiteralExpressionSegment#getText()` before generic literal 
formatting in `InsertValue`.
   - Add a focused unit test for preserving `DATE '2017-08-08'` in insert 
values.
   
   ### Verification
   
   - `./mvnw -pl infra/rewrite/core -am -DskipITs -Dspotless.skip=true 
-Dtest=InsertValueTest -Dsurefire.failIfNoSpecifiedTests=false test`
   - `./mvnw spotless:apply -Pcheck -T1C`
   - `./mvnw checkstyle:check -Pcheck -T1C`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to