strongduanmu commented on PR #38899:
URL: https://github.com/apache/shardingsphere/pull/38899#issuecomment-4779960087
### Summary
**Review Result: Mergeable**
Reason: The PR is scoped to one SQL E2E test class, reuses the existing
`DatabaseTypeRegistry.formatIdentifierPattern(...)` behavior for JDBC metadata
table/column lookups, and I did not find a merge-blocking
regression, scope issue, or style/compile failure.
### Evidence
- The changed scope is limited to
`test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/ddl/DDLE2EIT.java`.
- The setup/teardown metadata wait path now carries
`AssertionTestParameter`, so table existence checks can use the current
database type when reading JDBC metadata.
- `containsTable(...)` and column metadata lookup now apply
`DatabaseTypeRegistry.formatIdentifierPattern(...)`, matching the existing
database identifier pattern abstraction.
- No production code, public API/SPI, configuration, dependency,
distribution artifact, release note, or user documentation path is touched.
- GitHub status check rollup showed no failures: 62 successful checks and
2 skipped operation E2E checks.
### Review Details
Reviewed Scope: PR head `4b26f55296081a4f122a58358b0d15cecd8417c1`;
merge-base `464662d666bb8b67b618dc336887850ae146199c`; one changed file,
`test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/
sql/ddl/DDLE2EIT.java`. Local triple-dot file list matched GitHub
`/pulls/38899/files`.
Not Reviewed Scope: I did not run the full SQL E2E matrix across database
containers locally.
Verification:
- `./mvnw -pl test/e2e/sql -am -DskipITs -Dspotless.skip=true
-Dcheckstyle.skip=true -DskipTests test-compile` exited 0.
- `./mvnw -pl test/e2e/sql -Pcheck -DskipTests -DskipITs spotless:check
checkstyle:check` exited 0.
- Local review inventory script confirmed the GitHub file list matched the
local triple-dot scope.
Release Note / User Docs: Not required because this is a test-only
refactor with no user-visible behavior or configuration change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
