terrymanu commented on PR #38829: URL: https://github.com/apache/shardingsphere/pull/38829#issuecomment-4785873406
### Summary **Review Result: Mergeable** **Reason:** The latest head fixes the temporary-table DDL path for the reported MySQL Proxy issue and the previously reported Doris/shared-kernel gap. The parser flag propagation, binder copy, pre-execution rejection, and regression tests now line up with the root-cause path. ### Evidence - `CreateTableStatement` / `DropTableStatement` now carry the `temporary` flag, and binders preserve it through binding. - MySQL and Doris visitors now set the flag for `CREATE TEMPORARY TABLE` and `DROP TEMPORARY TABLE`. - `KernelProcessor` rejects temporary-table DDL before route/rewrite/execution, including when metadata validation is skipped. - Proxy connector coverage verifies the unsupported exception prevents push-down metadata refresh from being constructed. - Public check-runs for latest head `c359113d6fa4a73cb9d681bda3f01a45937c4e71` are green: 79 successful check runs, including Spotless, CheckStyle, CI, and E2E jobs. ### Review Details - **Reviewed Scope:** Latest PR head `c359113d6fa4a73cb9d681bda3f01a45937c4e71`; local merge-base `1e890783241fe4de1b781d3feb945b687d526205`. GitHub `/pulls/38829/files` matched the local triple-dot diff file list: 11 files across `infra/binder/core`, `infra/context`, `parser/sql/engine/dialect/mysql`, `parser/sql/engine/dialect/doris`, `parser/sql/statement/core`, and `proxy/backend/core`. - **Not Reviewed Scope:** I did not run local Maven, full Proxy startup, or packet/client smoke. Broader non-target dialect temporary-table policy was treated as outside this MySQL/Doris fix. - **Verification:** GitHub PR/files/reviews/comments/check-runs API checks succeeded; `git fetch apache master:refs/remotes/apache/master pull/38829/head:refs/remotes/apache/pr/38829` exit `0`; review inventory script exit `0`; local file-list comparison exit `0` and matched GitHub scope. - **Release Note / User Docs:** Not blocking for this PR. A release-note follow-up can be handled separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
