iamhucong commented on PR #38912:
URL: https://github.com/apache/shardingsphere/pull/38912#issuecomment-4796334257
### Summary
**Review Result: Mergeable**
Reason: The PR is scoped to the E2E Proxy Docker connection URL seam,
preserves existing default URL behavior, updates both Docker Proxy connection
call sites, and has direct unit/style plus relevant public CI evidence.
### Evidence
- `StorageContainerConnectOption.java:60-62` adds `getProxyURL(...)` as a
default method delegating to the existing `getURL(...)`, so existing dialect
implementations keep their current behavior unless they explicitly override it.
- `ShardingSphereProxyDockerContainer.java:66-76` now uses the proxy URL
seam for both readiness checking and target `DataSource` creation.
- Non-target storage paths still use the storage URL path, e.g.
`DockerStorageContainer.java:130-143,187-188` and
`NativeStorageContainer.java:91-110`.
- `StorageContainerConnectOptionTest.java:28-32` directly validates the
default delegation behavior.
- Public checks for head `52a1f3461f264e774b4557d42e85ee7d43667df3` showed
71 completed successful check-runs, including Proxy Cluster MySQL/PostgreSQL
E2E checks.
### Review Details
- Reviewed Scope: PR #38912 head `52a1f3461f264e774b4557d42e85ee7d43667df3`;
base ref `master`; local merge-base `6b46d9854c4d58b4adaf10ce21faf78f1d33faed`.
Reviewed all 3 files from GitHub `/pulls/38912/files`; the local triple-dot
file list matched GitHub.
- Not Reviewed Scope: No manual Docker startup beyond public CI evidence; no
dependency, distribution, release artifact, or user documentation paths were
changed.
- Verification:
- `./mvnw -pl test/e2e/env -am -DskipTests=false
-Dtest=StorageContainerConnectOptionTest
-Dsurefire.failIfNoSpecifiedTests=false test` exited 0; `Tests run: 1,
Failures: 0, Errors: 0`.
- `./mvnw -Pcheck -pl test/e2e/env -am -DskipTests spotless:check
checkstyle:check` exited 0; build successful with 0 Checkstyle violations.
- GitHub check-runs for the reviewed head: 71 completed, 71 successful.
- Release Note / User Docs: Not required; this only changes internal E2E
test-environment connection helpers and does not change user-facing behavior,
configuration, migration, or troubleshooting guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
