strongduanmu commented on PR #38915:
URL: https://github.com/apache/shardingsphere/pull/38915#issuecomment-4796485827
### Summary
**Review Result: Mergeable**
Reason: The latest patch fixes the reported unit-test failures, keeps the
change scope limited to encrypt rewrite, binder insert-value context, and
shared expression extraction, and the available verification indicates the PR
is ready to merge.
### Evidence
The previous concern around INSERT value parameter counting is treated as
non-blocking after E2E verification passed. The code path still has a shared
extractor and encrypt token interaction worth watching, but there is no
confirmed failing case in the
current PR evidence.
The PR updates `ExpressionExtractor#getParameterMarkerExpressions(...)`,
`InsertValueContext`, and encrypt rewrite token generators consistently enough
for the current refactor scope. The added/fixed unit tests cover the previously
failing insert statement
context and encrypt assignment token generator cases.
### Review Details
Reviewed Scope: PR #38915 latest head
`cc6727df2b7a2a370f1f5f18df83b5553998d3e4`; base ref `master`; local merge-base
`6b46d9854c4d58b4adaf10ce21faf78f1d33faed`. Local diff file list matched GitHub
`/pulls/38915/files` 13/13.
Verification: CI and E2E are reported as passing. Local verification on
the same head passed for release build, Checkstyle, RAT, and review inventory.
Release Note / User Docs: Not required for this internal rewrite and
binder behavior refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
