yx9o commented on PR #38934: URL: https://github.com/apache/shardingsphere/pull/38934#issuecomment-4817259659
### Summary - **Review Result: Mergeable** - Reason: The PR is a scoped prerequisite for #38933: it updates native-test database image versions, aligns the Presto test driver with the Presto image, updates matching optional-plugin docs, and refreshes generated native reachability metadata without a confirmed blocker. ### Evidence - The Presto version is consistently updated from `0.296` to `0.298.1` in `pom.xml`, the Presto optional-plugin docs, and `test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/databases/PrestoTest.java`. - The changed container image references are internally consistent across the touched docs, native Java tests, Testcontainers YAML files, and SQL Server license acceptance entry. - The PR body explicitly scopes this as part of #38933 and as the prerequisite database/native-test dependency update, so it does not over-claim full completion of the remaining Presto local-transaction work. - Public checks for the latest head are green, including Spotless, Checkstyle, License, CI, MCP unit tests, and GraalVM native checks on Linux and Windows. ### Review Details - Reviewed Scope: latest PR head `3b6fc7add75926d01f7e34891333c1d6c6f1325b`; GitHub `/pulls/38934/files` reports 26 changed files. Reviewed optional-plugin docs, `pom.xml`, native-test Java container definitions, native-test YAML container URLs, `container-license-acceptance.txt`, generated reachability metadata scope, linked issue #38933, public comments/reviews, commits, and check-runs. No local PR ref checkout or merge-base was used; GitHub file list and diff were used as the authoritative scope. - Not Reviewed Scope: local execution of native tests; manual re-generation or full line-by-line re-derivation of every generated reachability metadata entry. - Verification: Reviewed public PR metadata, diff, changed-file list, linked issue, comments, reviews, commits, and current-head check-runs. No local Maven/native-test command was run; current-head GitHub checks provide the runtime/style/license/native-image evidence for this dependency and generated-metadata update. - Release Note / User Docs: User docs are updated for the touched optional-plugin image examples. Release note is not required because this is test/documentation dependency and image maintenance without a runtime API, configuration, or migration change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
