vasiliy-mikhailov commented on PR #38932: URL: https://github.com/apache/shardingsphere/pull/38932#issuecomment-4828723213
Thanks for the thorough review, both points addressed. 1. Timezone test: since EPOCH is a static final computed at class load, a test-level TimeZone.setDefault cannot reliably control it (the class may already be loaded by an earlier test in the JVM). I added a scoped Surefire user.timezone=Asia/Shanghai to the snowflake module pom, which forces a non-UTC default for the whole test JVM before the class loads. Verified locally: with this override the test passes on the new UTC-based code, and fails on the previous implementation (Expected: is <1477958400000L>, the old offset-based value is 8 hours off), so it is now a real regression regardless of the runner timezone. 2. Release notes: added a 5.5.4 Bug Fixes entry for the UTC epoch change. Note for users: non-UTC deployments will see different generated key values after upgrading, since the epoch baseline shifts to UTC. Pushed both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
