terrymanu commented on PR #38977:
URL: https://github.com/apache/shardingsphere/pull/38977#issuecomment-4858696980
### Summary
**Review Result: Mergeable**
Reason: This Code Correctness Review covered the latest PR head for
documentation correctness, source-contract consistency, and change scope. I
found no code-level or documentation-level blockers. This is code-scope
readiness only; CI not reviewed by request.
### Evidence
- The CDC Streaming DistSQL syntax pages match the existing grammar and
visitor entries: `SHOW STREAMING RULE`, `ALTER STREAMING RULE`, `SHOW STREAMING
LIST`, `SHOW STREAMING STATUS`, and `DROP STREAMING` are covered by
`kernel/data-pipeline/scenario/cdc/distsql/parser/src/main/antlr4/imports/cdc/RALStatement.g4:22`
and
`kernel/data-pipeline/scenario/cdc/distsql/parser/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/distsql/parser/core/CDCDistSQLStatementVisitor.java:57`.
- The documented result columns match the executor output: `SHOW STREAMING
LIST` maps to
`kernel/data-pipeline/scenario/cdc/distsql/handler/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/distsql/handler/query/ShowStreamingListExecutor.java:41`,
`SHOW STREAMING STATUS` maps to
`kernel/data-pipeline/scenario/cdc/distsql/handler/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/distsql/handler/query/ShowStreamingJobStatusExecutor.java:45`,
and `SHOW STREAMING RULE` maps to
`kernel/data-pipeline/distsql/handler/src/main/java/org/apache/shardingsphere/data/pipeline/distsql/handler/transmission/query/ShowTransmissionRuleQueryResult.java:62`.
- The `DROP STREAMING` docs no longer claim a “no subscriptions”
precondition that is not enforced by the DistSQL path. The current wording
matches
`kernel/data-pipeline/scenario/cdc/distsql/handler/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/distsql/handler/update/DropStreamingExecutor.java:35`
and
`kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/CDCJobAPI.java:264`.
The openGauss replication-slot cleanup note is supported by
`kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/CDCJobAPI.java:270`
and
`kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/incremental/wal/position/OpenGaussIncrementalPositionManager.java:62`.
- The documented `agent-plugins-enabled` property and
`metadata-identifier-case-sensitivity` values/defaults match
`infra/common/src/main/java/org/apache/shardingsphere/infra/config/props/ConfigurationPropertyKey.java:136`,
`infra/common/src/main/java/org/apache/shardingsphere/infra/config/props/MetadataIdentifierCaseSensitivity.java:23`,
and
`infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/ConfigurationPropertiesTest.java:85`.
- I found no remaining references in the changed files to `SHOW TEMP DIST
VARIABLES`, `Global Clock`, `Proxy Native`, `Proxy labels`, or the corrected
“no subscriptions / can only be deleted when there are no subscriptions”
wording.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope: 26 authoritative docs files from GitHub
`/pulls/38977/files`, including CDC streaming DistSQL syntax pages, CDC
build/usage links, common/proxy property docs, `SHOW DIST VARIABLES` examples,
reserved words, and database compatibility docs. Latest PR head SHA:
`ee9bb7841708527630c668da2050125b79b897b6`; local merge-base SHA:
`8bbf402e53b4db74e24faddbecb199bf189d6cef`; the local triple-dot file list
matched GitHub `/pulls/{number}/files`.
- Not Reviewed Scope: GitHub Actions/check-runs/workflow logs were not
reviewed; no CDC/Proxy runtime smoke test was run.
- Verification: `./mvnw spotless:check -Pcheck -T1C` exited with 0. GitHub
PR metadata/files/comments/reviews endpoints were accessible; public
comments/reviews did not contain counter-evidence. Full-coverage review ledger
validation passed. Checkstyle/RAT were not run locally because this is a
docs-only Code Correctness Review and CI was not reviewed by request.
- Release Note / User Docs: User docs are the PR scope and were reviewed. A
separate release note is not required for this docs-only correction/update PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
