terrymanu commented on PR #38993: URL: https://github.com/apache/shardingsphere/pull/38993#issuecomment-4881685262
### Summary **Review Result: Mergeable** Reason: Code-scope only: the latest PR version adds a root no-testing-through-layers rule and threads that ownership boundary through the gen-ut skill’s branch mapping, mocking, parameterization, trimming, and workflow steps. I did not find a code-level blocker in the reviewed scope. CI not reviewed by request. ### Evidence - `AGENTS.md:124-127` defines no testing through layers and requires unit tests to separate SUT-owned behavior from collaborator-owned rules, mock the nearest stable collaborator boundary, and leave cross-layer checks to integration, contract, or E2E scopes. - `.codex/skills/gen-ut/SKILL.md:45-47` defines SUT-owned behavior, collaborator-owned behavior, and testing through layers; `.codex/skills/gen-ut/SKILL.md:80-81` prevents counting collaborator rules as target-class branches; `.codex/skills/gen-ut/SKILL.md:106-107` requires mocking collaborator results at stable boundaries. - `.codex/skills/gen-ut/SKILL.md:126`, `.codex/skills/gen-ut/SKILL.md:172`, and `.codex/skills/gen-ut/SKILL.md:207` carry the same boundary into parameterization suitability, test trimming, and the R4 workflow record, so the new root rule is not isolated to `AGENTS.md`. - The PR changes only agent/test-generation guidance files; no production, runtime, dependency, distribution, SQL parser, protocol, or generated contract surface is touched, so release notes/user docs are not required for this PR. ### Review Details - Review Focus: Code Correctness Review. CI not reviewed by request. - Reviewed Scope: `AGENTS.md` and `.codex/skills/gen-ut/SKILL.md` at head `eaf1da5be1e21248efeeaa37836ccfeaccd19721`; base/merge-base `9ef9566bd7feedc9dfd55f17bc456fe3f95f43dd`; local triple-dot file list matched GitHub `/pulls/38993/files`. - Not Reviewed Scope: GitHub Actions/check-runs/workflow logs, full Maven build, and unrelated repository areas outside the two changed guidance files. - Verification: GitHub public REST metadata/files/comments/reviews fetched successfully; PR has 2 changed files, 1 commit, no issue comments, no reviews, and no review comments. `git fetch apache master:refs/remotes/apache/master pull/38993/head:refs/remotes/apache/pr/38993` exited 0. The local triple-dot file list matched GitHub’s file list. Static diff and targeted `git grep` over the new ownership terms exited 0. I did not run Maven/Spotless/Checkstyle because this is Markdown guidance/skill text only and no executable code path changed. - Release Note / User Docs: Not required; this is internal AI-agent guidance, not user-facing product behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
