terrymanu commented on PR #39002: URL: https://github.com/apache/shardingsphere/pull/39002#issuecomment-4884746824
### Summary **Review Result: Mergeable** Reason: Code-scope review only. The PR is a focused MCP E2E test-support refactor, and I did not find a code-level blocker in the reviewed scope. CI not reviewed by request. ### Evidence - `MCPInteractionClient` now expresses the real shared client contract by removing default `UnsupportedOperationException` methods. The concrete HTTP and STDIO clients still inherit the common implementations through `AbstractMCPInteractionClient`, and the only direct test fake implementation is updated. - `PackagedDistributionTestSupport` keeps the same prepare/rewrite behavior while removing duplicated distribution preparation, YAML writing, and transport-type mapping logic. - `PackagedDistributionTestSupportTest` adds direct coverage for `createDockerConfigurationFile` across HTTP and STDIO transports, including transport type and runtime database preservation. - No POM files, Maven modules, or test-jar declarations are changed. ### Review Details - Review Focus: Code Correctness Review. CI not reviewed by request. - Reviewed Scope: PR #39002, head `55936d809e5c0805fc727bafd1b1e603fbdc5413`, base/merge-base `12e9129f148fb30b943dfb671d616f68d991fced`. Reviewed all 5 changed files under `test/e2e/mcp`; local `base...head` file list matched GitHub `/pulls/39002/files`. - Not Reviewed Scope: GitHub Actions/check-runs, full Docker E2E execution, and files outside the PR diff. - Verification: Ran `./mvnw -pl test/e2e/mcp -DskipITs -Dtest=AbstractMCPInteractionClientTest,LLMMCPActionExecutorTest,PackagedDistributionTestSupportTest -Dsurefire.failIfNoSpecifiedTests=false test -Pcheck`; exit 0, 32 tests passed. - Release Note / User Docs: Not required; this is test-support refactoring with no user-facing behavior or configuration change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
