terrymanu commented on PR #39010: URL: https://github.com/apache/shardingsphere/pull/39010#issuecomment-4886220305
### Summary **Review Result: Mergeable** Reason: Code-scope only: this PR only refactors checked exception declarations in `BootstrapInitializerTest`, and I found no code-level blocker. CI not reviewed by request. ### Evidence - Latest head `8d2f14c013b9016f5cf7da299b1c40cb80981dbf` changes only `proxy/bootstrap/src/test/java/org/apache/shardingsphere/proxy/initializer/BootstrapInitializerTest.java`. - The change moves `ReflectiveOperationException` handling into the private `registerSingletonService(...)` helper via `@SneakyThrows(ReflectiveOperationException.class)` and removes the same checked exception from three test method signatures. - Test behavior and assertions are unchanged; no production code, public API, dependency, distribution, or user-facing documentation surface is touched. ### Review Details - Review Focus: Code Correctness Review; CI not reviewed by request. - Reviewed Scope: `proxy/bootstrap/src/test/java/org/apache/shardingsphere/proxy/initializer/BootstrapInitializerTest.java`; head `8d2f14c013b9016f5cf7da299b1c40cb80981dbf`; merge-base `2fdd007a462184ad2824895f2d32a16e0f2ba288`; local changed-file list matched GitHub `/pulls/39010/files`. - Not Reviewed Scope: GitHub Actions / CI, full module test execution, and unrelated repository files. - Verification: GitHub PR metadata/files/comments/reviews were fetched through public API; local `git diff --name-status` and focused diff inspection completed with exit code 0. Maven was not run because the request was for a quick code-scope review and the patch is test-only signature cleanup. - Release Note / User Docs: Not required; no user-facing behavior changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
