terrymanu commented on PR #39012: URL: https://github.com/apache/shardingsphere/pull/39012#issuecomment-4886306460
### Summary **Review Result: Mergeable** Reason: Code-scope only. The PR removes unused DistSQL `LABEL`, `RELABEL`, and `UNLABEL` lexer tokens and keeps the Proxy DistSQL reserved-word docs in sync; I did not find a code-level blocker. CI not reviewed by request. ### Evidence - `parser/distsql/engine/src/main/antlr4/imports/Keyword.g4:182` now flows from `MODE` directly to `EXPORT`, so the three unsupported label tokens are no longer reserved by the shared DistSQL lexer. - `parser/distsql/engine/src/main/antlr4/imports/RALStatement.g4:34` covers the current compute-node RAL grammar, and there is still no `LABEL` / `RELABEL` / `UNLABEL` parser rule or statement path to preserve. - `parser/distsql/engine/src/main/antlr4/imports/Literals.g4:22` still allows these words to fall back to `IDENTIFIER_`, which is the intended result after removing unused keyword tokens. - `docs/document/content/user-manual/shardingsphere-proxy/distsql/syntax/reserved-word.en.md:91` and `docs/document/content/user-manual/shardingsphere-proxy/distsql/syntax/reserved-word.cn.md:90` were updated consistently with the lexer cleanup. - A scoped search on the PR head found no remaining `LABEL`, `RELABEL`, or `UNLABEL` references under the DistSQL grammar and Proxy DistSQL reserved-word docs. ### Review Details - Review Focus: Code Correctness Review. CI not reviewed by request. - Reviewed Scope: PR #39012, latest head `7063d65c451b745078eadcf4d0083049cc23db34`, base `master` at `35a1ce7295fcba0d3bf882c2cedec210b354b038`, merge-base `35a1ce7295fcba0d3bf882c2cedec210b354b038`. Reviewed files: `parser/distsql/engine/src/main/antlr4/imports/Keyword.g4`, `docs/document/content/user-manual/shardingsphere-proxy/distsql/syntax/reserved-word.en.md`, and `docs/document/content/user-manual/shardingsphere-proxy/distsql/syntax/reserved-word.cn.md`. Local triple-dot file list matched GitHub `/pulls/39012/files`. - SQL parser scope: Target syntax is ShardingSphere DistSQL RAL shared lexer, not a database dialect grammar. Related database trunk/branch dialect parser checks are not applicable. Checked DistSQL grammar paths `Keyword.g4`, `RALStatement.g4`, `BaseRule.g4`, `Literals.g4`, and the Proxy DistSQL reserved-word docs. - Not Reviewed Scope: GitHub Actions/check-runs, full repository test suite, and runtime Proxy smoke tests were not reviewed. - Verification: `./mvnw -pl parser/distsql/engine -am -DskipTests -Pcheck -T1C compile` exited 0; `./mvnw spotless:check -Pcheck -T1C` exited 0; `./mvnw checkstyle:check -Pcheck -T1C` exited 0. - Release Note / User Docs: User docs were updated in this PR. A release note is not required for this cleanup because it removes unsupported unused reserved tokens and does not require migration guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
