terrymanu commented on PR #39021: URL: https://github.com/apache/shardingsphere/pull/39021#issuecomment-4891923336
### Summary **Review Result: Mergeable** Reason: Code-scope review of the latest PR head did not find a confirmed blocker. This result is code-scope only; CI was not reviewed by request. ### Evidence - `mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/completion/provider/WorkflowPlanIdCompletionProvider.java:58` now derives workflow-kind constraints from the completion target before listing current-session plans, and keeps the previous behavior when no related workflow kind is found via the empty-set fallback at line 72. - `mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/descriptor/MCPDescriptorCatalogIndex.java:126` maps prompt names only when the exact `database_gateway_` planning tool exists, is listed in `related-tools`, and has `workflowRole=plan`; non-prompt completion targets still return no restriction at lines 240-244. - `mcp/bootstrap/src/test/java/org/apache/shardingsphere/mcp/bootstrap/transport/capability/completion/MCPCompletionSpecificationFactoryTest.java:156` covers the root behavior by mixing `encrypt.rule` and `mask.rule` plans in one session and verifying `plan_encrypt_rule` completion returns only the encrypt plan. - `mcp/features/encrypt/src/main/resources/META-INF/shardingsphere-mcp/mcp-descriptors/mcp-descriptor-encrypt.yaml:476` and `mcp/features/sharding/src/main/resources/META-INF/shardingsphere-mcp/mcp-descriptors/mcp-descriptor-sharding.yaml:858` show the descriptor examples now provide an actionable `database_gateway_apply_workflow` preview call with `plan_id` and `execution_mode`. - Static descriptor checks against the latest PR head confirmed every feature planning tool example uses `database_gateway_apply_workflow` with `execution_mode` and `plan_id`, and every exact prompt-to-planning-tool mapping has `related-tools`, `workflowRole=plan`, and `workflow-kind`. ### Review Details - Review Focus: Code Correctness Review. CI not reviewed by request. - Reviewed Scope: PR #39021 latest head `d2944f40385c33e7518dc68f45512590956ac140`, base `master@3c5c1d85b3902ac36d86dd6704d36f6c1e1e9002`, merge-base `3c5c1d85b3902ac36d86dd6704d36f6c1e1e9002`. Reviewed all 15 files reported by GitHub `/pulls/39021/files`; the local triple-dot file list matched GitHub. - Not Reviewed Scope: GitHub Actions/check-runs and Actions logs were not reviewed; no full repository `clean install` or MCP E2E runtime scenario was run. - Verification: Ran scoped MCP tests for support/core/feature descriptor/bootstrap completion coverage with exit code 0. Ran `./mvnw checkstyle:check -Pcheck -T1C` with exit code 0. Ran static descriptor scans for planning `next_actions` and prompt workflow-kind mappings with exit code 0. - Release Note / User Docs: Not required; the PR changes MCP completion behavior, model-facing descriptor examples, and tests without adding user configuration, migration steps, or compatibility requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
