strongduanmu commented on PR #39008:
URL: https://github.com/apache/shardingsphere/pull/39008#issuecomment-4899311720
• ### Summary
**Review Result: Mergeable**
**Feedback Mode: Approve**
The previously reported `LATERAL VIEW` issue has been fixed. The current
implementation now supports omitted lateral-view column aliases in the Hive
grammar, handles missing `columnNames()` safely in the visitor, and adds the
corresponding parser IT case and baseline.
### Issues
No blocking correctness issues found in the current review scope.
### Evidence
- `lateralView` now allows optional column aliases via `(AS columnNames)?`.
- `HiveDMLStatementVisitor` handles missing `columnNames()` before adding
function table columns.
- Parser IT coverage includes a `LATERAL VIEW explode(...) alias` case
without column aliases.
- Related binder and statement changes are consistent with function table
columns being optional.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope: Hive parser grammar, Hive DML visitor, parser IT SQL
cases and baselines, related binder/statement adjustments, and MCP expectation
updates.
- Deferred Scope: `TABLESAMPLE(BUCKET ... OUT OF ...)` without `ON`, and
`MAP/REDUCE` transform tails with `DISTRIBUTE BY ... SORT BY ...` are treated
as future enhancement scope per follow-up decision.
- Verification: Static review of the latest PR diff only; no additional CI
or Maven command was rerun as part of this review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
