terrymanu commented on PR #39027: URL: https://github.com/apache/shardingsphere/pull/39027#issuecomment-4900658200
### Summary **Review Result: Mergeable** Reason: This is code-scope only for Code Correctness Review; CI was not reviewed by request. The PR adds a narrow execution rule in `AGENTS.md` that operationalizes the existing Lombok preference from `CODE_OF_CONDUCT.md` without changing production code, public APIs, runtime behavior, or test behavior. ### Evidence - `CODE_OF_CONDUCT.md:65` already declares the source-of-truth style rule: prefer Lombok instead of constructors, getters, setters, and log variables. - `AGENTS.md:48` adds an agent-facing trigger scoped to "adding or touching" boilerplate members, so it does not ask for unrelated sweeping rewrites. - `AGENTS.md:49` gives concrete narrow annotations for private utility constructors, plain constructors, and accessors. - `AGENTS.md:50` explicitly protects public constructors/accessors by requiring signature, access-level, parameter-order, annotation, reflection, and serialization checks before replacement. - `AGENTS.md:51` preserves manual code when Lombok would hide logic, validation, defaults, side effects, compatibility requirements, framework/reflection semantics, or public-contract details. - `AGENTS.md:52` avoids the common over-generation risk by rejecting broad Lombok annotations such as `@Data` unless every generated behavior is intentionally required. ### Review Details - Review Focus: Code Correctness Review; CI not reviewed by request. - Reviewed Scope: PR `apache/shardingsphere#39027`, latest head `b55410a38ab79c3192614b9f94a1d521c92e85d8`, base `master` at `f005143f26a1448e262a0f43db6da028754de57d`, merge-base `f005143f26a1448e262a0f43db6da028754de57d`. Reviewed `AGENTS.md`; local triple-dot file list matched GitHub `/pulls/39027/files`. - Not Reviewed Scope: GitHub Actions/check-runs, workflow logs, runtime behavior, production Java code, and tests outside the changed documentation rule. - Verification: `./mvnw spotless:check -Pcheck -T1C` exited `0`; `./mvnw checkstyle:check -Pcheck -T1C` exited `0`. GitHub PR metadata, files, commits, issue comments, review comments, and reviews were accessible; no public comments or reviews were present at review time. - Release Note / User Docs: Not required because this change only updates AI agent maintenance guidance and has no user-facing runtime, configuration, migration, or compatibility impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
