menghaoranss commented on PR #39039:
URL: https://github.com/apache/shardingsphere/pull/39039#issuecomment-4904914037
```markdown
### Summary
**Review Result: Mergeable**
Reason: Code-scope only. CI not reviewed by request. The PR removes
redundant `@Getter(AccessLevel.NONE)` annotations from fields that are not
covered by any class-level Lombok getter, so it does not expose new accessors
or change runtime behavior.
### Evidence
-
`infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java:41-55`
still has `@Getter` only on `name` and `protocolType`; there is no class-level
`@Getter`, so removing field-level `@Getter(AccessLevel.NONE)` from
`identifierContext`, `tableIndex`, `logicalTableIndex`, and `viewIndex` is
behavior-neutral.
- The unused `lombok.AccessLevel` import is removed, and the class still
compiles with the same explicit public API methods for schema/table/view access.
- A repository search on the PR head found no remaining
`@Getter(AccessLevel.NONE)` or `lombok.AccessLevel` usage in
`ShardingSphereSchema`.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope:
`infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java`.
Latest PR head SHA: `2bf82cc50bc4c50d18b6a01fd4d0c53926785d0e`. Base ref:
`apache:master`, base SHA from PR metadata:
`91a4e27823054d1050db1856c57e0dbdf5912736`. Local merge-base SHA:
`91a4e27823054d1050db1856c57e0dbdf5912736`. Local triple-dot file list matched
GitHub `/pulls/39039/files`.
- Not Reviewed Scope: GitHub Actions/check-runs/logs, repository merge gate
status, and modules outside the single changed file.
- Verification:
- `git fetch upstream pull/39039/head:refs/remotes/upstream/pr/39039`:
exit 0.
- `git diff --name-only upstream/master...upstream/pr/39039`: exit 0;
matched the one GitHub changed file.
- `./mvnw -pl infra/common -DskipTests compile -Pcheck -T1C`: exit 0,
`BUILD SUCCESS`.
- `git diff --check upstream/master...upstream/pr/39039`: exit 0.
- Release Note / User Docs: Not required. This is an internal
annotation/import cleanup with no user-facing behavior, configuration,
compatibility, diagnostics, or migration impact.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
