menghaoranss commented on PR #39045:
URL: https://github.com/apache/shardingsphere/pull/39045#issuecomment-4910882925
```markdown
### Summary
**Review Result:** Mergeable
**Reason:** The PR makes the federation metadata refresh path use
`SchemaRefreshUtils.getActualSchemaName(...)` instead of the old lowercase-only
`getSchemaName(...)`, which aligns federation refresh behavior with the
existing push-down metadata refresh path and avoids losing the actual schema
casing. I did not find a code-correctness blocker in the changed files.
### Evidence
- `FederationMetaDataRefreshEngine.refresh(...)` now passes
`SchemaRefreshUtils.getActualSchemaName(database, sqlStatementContext)` to the
selected `FederationMetaDataRefresher`, so create/alter/drop view federation
refresh receives the same actual-schema resolution semantics used elsewhere in
metadata refresh.
- `SchemaRefreshUtils.getActualSchemaName(...)` resolves the schema from the
SQL statement context, matches existing schema names through the database
identifier policy, and only falls back to policy normalization or the original
identifier when no existing schema matches. This is the intended behavior for
preserving actual schema names instead of unconditional lowercasing.
- Repository search found no remaining callers of the removed
`SchemaRefreshUtils.getSchemaName(...)` method, so removing that lowercase-only
helper does not leave unresolved production references.
- The touched federation test expectations were updated to mock
`getActualSchemaName(...)`, matching the new production call.
### Review Details
- PR reviewed: apache/shardingsphere#39045
- Scope reviewed: changed production and test files under
`mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/...`
and
`mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/refresher/...`
- CI not reviewed by request.
- Local verification:
- `./mvnw -pl mode/core -DskipTests compile -Pcheck -T1C` passed.
- `./mvnw -pl mode/core -Dtest=SchemaRefreshUtilsTest test -Pcheck -T1C`
passed.
- `./mvnw -pl mode/core
-Dtest=SchemaRefreshUtilsTest,FederationMetaDataRefreshEngineTest test -Pcheck
-T1C` did not complete successfully because the local Mockito inline mock maker
failed to initialize the Byte Buddy agent before executing
`FederationMetaDataRefreshEngineTest`. This appears to be a local
test-environment/tooling limitation, not evidence of a PR behavior regression.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
