terrymanu commented on PR #39048:
URL: https://github.com/apache/shardingsphere/pull/39048#issuecomment-4912062408
### Summary
**Review Result: Mergeable**
Reason: Code-scope review only; CI not reviewed by request. The PR is
limited to MCP E2E contract coverage and the added assertions align with the
claimed behavior without changing production code or broadening scope.
### Evidence
-
`test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/runtime/programmatic/FeatureWorkflowContractE2ETest.java`
now verifies feature workflow tools through the public MCP HTTP surface:
`tools/list` exposes the expected plan arguments, `additionalProperties`
remains disabled, and unsupported arguments return a tool error with structured
validation recovery.
-
`test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/runtime/production/HttpProductionProxyFeatureWorkflowContractE2ETest.java`
now checks duplicate create requests after successful Proxy apply/validate for
broadcast, readwrite-splitting, shadow, and sharding workflows.
-
`test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/runtime/programmatic/HttpTransportRecoveryE2ETest.java`
now verifies secret-reference plan and preview HTTP response bodies do not
expose the raw secret reference or label.
- No production API, runtime behavior, dependency, descriptor, or
distribution file is changed by this PR.
### Review Details
- Review Focus: Code Correctness Review; CI not reviewed by request.
- Reviewed Scope: PR `apache/shardingsphere#39048`, head
`72bb05f06de53c0f54f246a84aa31af09848f00a`, base
`af7378fe31a9f7e0f2dc421a8762d6d2c2104092`, merge-base
`af7378fe31a9f7e0f2dc421a8762d6d2c2104092`. The local changed-file list matched
GitHub `/pulls/39048/files`.
- Reviewed Files:
-
`test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/runtime/production/HttpProductionProxyFeatureWorkflowContractE2ETest.java`
-
`test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/runtime/programmatic/FeatureWorkflowContractE2ETest.java`
-
`test/e2e/mcp/src/test/java/org/apache/shardingsphere/test/e2e/mcp/runtime/programmatic/HttpTransportRecoveryE2ETest.java`
- Not Reviewed Scope: GitHub Actions/check-runs, full repository regression,
release packaging, and LLM E2E matrix were not reviewed.
- Verification:
- `./mvnw -pl test/e2e/mcp
-Dtest=FeatureWorkflowContractE2ETest,HttpTransportRecoveryE2ETest -DskipITs
-Dspotless.skip=true -Dcheckstyle.skip=true -De2e.run.type=DOCKER test -B -ntp`
passed: 9 tests, 0 failures.
- `./mvnw -pl test/e2e/mcp
-Dtest=HttpProductionProxyFeatureWorkflowContractE2ETest -DskipITs
-Dspotless.skip=true -Dcheckstyle.skip=true -De2e.run.type=DOCKER test -B -ntp`
passed: 8 tests, 0 failures.
- Release Note / User Docs: Not required; this is test-only E2E contract
coverage with no user-facing behavior or configuration change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
