terrymanu commented on PR #39074: URL: https://github.com/apache/shardingsphere/pull/39074#issuecomment-4949525648
Summary Review Result: Mergeable Reason: This conclusion is code-scope only; CI was not reviewed by request. No behavioral regressions, incorrect call chains, protocol contract breaks, or gaps in test coverage introduced by this PR were found. Evidence Fully reviewed 128 changed files, including 54 production files and 74 test files; the local file list is fully consistent with the GitHub PR file list. All six Sharding workflows are correctly routed to the unified ShardingWorkflowPlanningService; request isolation remains guaranteed by ShardingWorkflowRequest.merge. No residual references exist in the repository for the deleted constructors, overloads, wrapper types, and HTTP helper aliases. The MCP module was introduced after the 5.5.3 release, and the current version is 5.5.4-SNAPSHOT, so the removed public types are not part of the published compatibility contracts. HTTP request bodies, notifications and protocol versions are centrally managed by MCPInteractionProtocolSupport, whose direct tests and protocol E2E tests all pass. All Spotless checks, Checkstyle checks, 4,098 reactor tests, 42 E2E helper tests and 25 HTTP protocol contract tests have passed. Review Details Review Focus: Code Correctness Review; CI not reviewed by request Reviewed Scope: PR #39074, latest head 98832c394d3a63a203a8a3aeefd8d93f4a4a5cc6; merge-base 398e63e26b6878375cc0c582dbb101c33eeaf31d; GitHub file list matches local file list (128/128). Not Reviewed Scope: GitHub Actions, external LLMs, Docker, and full distribution runtime E2E tests. Verification: Affected MCP module reactor tests, targeted E2E helper tests, HttpTransportProtocolContractE2ETest, spotless:check and checkstyle:check all completed with exit code 0. Public Evidence: GitHub PR data, files, comments and review REST data are accessible; there are no evidence gaps affecting this conclusion. Release Note / User Docs: Not required; this change does not modify model-visible tool names, resource URIs, schemas, payloads or runtime behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
