thswlsqls opened a new pull request, #39077:
URL: https://github.com/apache/shardingsphere/pull/39077
Fixes #39076.
Changes proposed in this pull request:
- Replace `klass.getClass().getName()` with `klass.getName()` in the three
error handlers of `StaticMethodAdviceExecutor` (`adviceBefore`, `adviceThrow`,
`adviceAfter`).
- `klass` is the `@Origin final Class<?>` target class, so
`klass.getClass()` always resolved to `java.lang.Class`, making every failure
log report `java.lang.Class` instead of the instrumented class.
- Aligns with the sibling `InstanceMethodAdviceExecutor`, which correctly
uses `target.getClass().getName()` because `target` is an instance.
- Add focused log assertions for the before, throwing, and after failure
paths to verify each SEVERE `LogRecord` reports the real target class name.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
