thswlsqls opened a new pull request, #39079:
URL: https://github.com/apache/shardingsphere/pull/39079
No issue: non-behavioral description typo fix.
Changes proposed in this pull request:
- Drop the stale `2 is LOCK` reference from the `proxy_state` metric
description in `ProxyStateExporter`; the `LOCK` value of `InstanceState` was
removed by merged PR #31312, leaving only `OK` (0) and `CIRCUIT_BREAK` (1), so
ordinal 2 can never be emitted.
- Apply the same correction to the `proxy_state` row in the proxy
observability user manual (`shardingsphere-proxy/observability/_index.en.md`)
so the docs match the code.
- Aligns with the sibling `JDBCStateExporter`, whose description was
already corrected to `0 is OK; 1 is CIRCUIT BREAK`.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
