Zhengcy05 opened a new pull request, #39081:
URL: https://github.com/apache/shardingsphere/pull/39081
Special note: Since there are many design changes this time, I sincerely
hope someone will carefully review this PR. Thx😘
Fixes #39051.
Changes proposed in this pull request:
-
- Track BLOB read state per connection and per blob handle.
- Make `OPEN_BLOB` register content and cursor state.
- Make `SEEK_BLOB` return the resulting cursor position.
- Make `GET_SEGMENT` read from the current cursor and return EOF correctly.
- Make `INFO_BLOB` read the current BLOB length from the same state.
- Clean up BLOB state on close, cancel, and connection release.
---
## Validation:
- `./mvnw -pl database/protocol/dialect/firebird -am -Dspotless.skip=true
-Dtest=FirebirdBlobRegistryTest,FirebirdBlobInfoReturnPacketTest
-Dsurefire.failIfNoSpecifiedTests=false test`
- `./mvnw -pl proxy/frontend/dialect/firebird -am -DskipITs
-Dspotless.skip=true -Djacoco.skip=true
-Dtest=FirebirdOpenBlobCommandExecutorTest,FirebirdCloseBlobCommandExecutorTest,FirebirdCancelBlobCommandExecutorTest,FirebirdGetBlobSegmentCommandExecutorTest,FirebirdSeekBlobCommandExecutorTest,FirebirdBlobInfoExecutorTest,FirebirdFrontendEngineTest,FirebirdAuthenticationEngineTest,FirebirdCommandExecuteEngineTest
-Dsurefire.failIfNoSpecifiedTests=false
-DargLine='-javaagent:/Users/didi/.m2/repository/net/bytebuddy/byte-buddy-agent/1.18.10/byte-buddy-agent-1.18.10.jar
-Djdk.attach.allowAttachSelf=true -XX:+EnableDynamicAgentLoading' test`
- `./mvnw spotless:apply -Pcheck -T1C`
- `./mvnw checkstyle:check -Pcheck -T1C`
```
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
