strongduanmu commented on PR #39082:
URL: https://github.com/apache/shardingsphere/pull/39082#issuecomment-4954475036
• ### Summary
**Review Result: Mergeable**
Reason: Code-scope only. The latest PR head preserves the existing
successful compile path and improves cleanup by moving
`RelMetadataQueryBase.THREAD_PROVIDERS.remove()` into `finally`; CI was not
reviewed by request.
### Evidence
-
`kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/compiler/SQLStatementCompiler.java:52`
now wraps the existing compile flow in `try/finally`, so the Calcite
thread-local metadata provider
is cleared on both normal and exceptional exits.
- The successful compile behavior remains covered by
`SQLStatementCompilerIT`, and the focused sentinel passed with 108 tests.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope:
`kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/compiler/SQLStatementCompiler.java`;
latest PR head `a94a006c9d8ba684b17a6c65b05e95ca0bf3c92d`; base ref `master`,
base SHA
and local merge-base `e3bff1a84847082fe67cf095a60392784f11daf6`; local
triple-dot changed-file list matched GitHub `/pulls/39082/files`.
- Not Reviewed Scope: GitHub Actions/check-runs and full repository build.
- Verification: GitHub PR metadata/files were rechecked and the head
remained `a94a006c9d8ba684b17a6c65b05e95ca0bf3c92d`. `./mvnw -pl
kernel/sql-federation/compiler -am -Dspotless.skip=true -Dcheckstyle.skip=true
-Dtest=org.apache.shardingsphere.sqlfederation.compiler.compiler.it.SQLStatementCompilerIT
-Dsurefire.failIfNoSpecifiedTests=false test` exited 0;
`SQLStatementCompilerIT` passed 108 tests. The first scoped run without `-am`
exited 1
because same-repo snapshot dependencies were not installed locally.
- Release Note / User Docs: Not required; this is an internal compiler
lifecycle cleanup with no user-facing configuration, SQL syntax, API, or
migration surface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
