sandynz commented on PR #39086:
URL: https://github.com/apache/shardingsphere/pull/39086#issuecomment-4956835825
### Correction
- **Previous Finding:** The Native Pipeline cleanup path must propagate
`e2e.native.database.host`.
- **Current Status:** Withdrawn
- **Reason:** The Pipeline E2E manual defines NATIVE execution as a local
topology and configures only port, username, and password. The shared
`NativeDatabaseEnvironment` host capability does not establish remote
Native Pipeline support. Expanding the cleanup SPI for that undocumented
scenario was unnecessary.
### Summary
**Review Result: Mergeable**
**Reason:** The latest branch state has no confirmed code-level blocker.
This result is code-scope only, and CI was not reviewed by request.
### Evidence
- Revert commit `9dcf23b16876b5bce282e7cb505c5e544b4a2c17` removes the
unnecessary `actualDatabaseHost` SPI expansion.
- The resulting tree matches `af53fec9291291c516964a3542036cd0ed90f5a5`.
- The Native storage SPI provides database-specific initialization, access
URL, data-source configuration, and ordered link replacement hooks while
preserving the existing behavior when no implementation is registered.
- Embedded Proxy replacement ordering is preserved with `LinkedHashMap`,
allowing specific connection URL replacements to run before generic host and
port replacements.
- Pipeline Oracle cleanup covers both Native SPI discovery and the
original fallback path.
- No unrelated production, configuration, dependency, distribution, or
documentation changes remain.
### Review Details
- **Review Focus:** Code Correctness Review. CI not reviewed by request.
- **Reviewed Scope:** All 7 files in
`upstream/master...9dcf23b16876b5bce282e7cb505c5e544b4a2c17`, covering E2E Env
Native storage customization, Embedded Proxy replacement handling, Native
storage lifecycle, and
Pipeline Oracle cleanup.
- **Merge Base:** `370a94d20f5a55f87b564b4f31ff65deccebb681`
- **Scope Source:** Local branch range requested by the user. No GitHub PR
number was provided, so the local file list was not compared with
`/pulls/{number}/files`.
- **Not Reviewed Scope:** GitHub checks and full database E2E execution.
- **Verification:** `spotless:check` exited 0; `checkstyle:check` exited
0; `NativeStorageContainerOptionTest` passed 4 tests;
`OraclePipelineNativeContainerDropTableOptionTest` passed 2 tests; IntelliJ
inspections
reported no errors in the 7 changed files.
- **Release Note / User Docs:** Not required because the changes affect
internal E2E test infrastructure only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
