terrymanu commented on PR #39087:
URL: https://github.com/apache/shardingsphere/pull/39087#issuecomment-4957134112
### Summary
**Review Result: Mergeable**
Reason: The PR removes the unused compatibility constructor, updates all
in-repository callers to the canonical structured constructor, and preserves
existing classification behavior. No code-level blocker was found. CI was not
reviewed by request.
### Evidence
- `ClassificationResult.java:61` retains only the package-private
constructor accepting structured referenced objects.
- `StatementClassifier.java:56` and `StatementClassifier.java:59` preserve
savepoint and transaction behavior by passing empty referenced-object
collections.
- Structured SQL classification remains unchanged at
`StatementClassifier.java:64`.
- `MCPSQLExecutionFacadeTest.java` preserves target-object semantics through
`SQLStatementObjectName.fromNormalizedName(...)`.
- `MCPErrorConverterTest.java:277` uses direct mocks for the converter
contract without widening production visibility.
- Repository-wide inspection found no remaining public compatibility
constructor or cross-package direct construction.
- The changed file list contains only the seven expected `mcp/core` files.
### Review Details
- Review Focus: `Code Correctness Review`; CI not reviewed by request.
- Reviewed Scope: PR head `1c5a857a45c7feee1128ff030df9350370aa5099`, base
`85bf3ae6ea74c91fe7862936dd6c4d5322e64457`, merge-base matches the base commit.
The local file list matches GitHub's seven changed files.
- Not Reviewed Scope: GitHub Actions, check runs, and broader E2E/runtime
smoke verification.
- Verification:
- `./mvnw checkstyle:check -Pcheck -T1C` — exit code 0.
- Focused `mcp/core` tests — 293 tests, 0 failures, exit code 0.
- Release Note / User Docs: Not required; this is an internal constructor
cleanup with no user-facing protocol, configuration, or SQL behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
