terrymanu commented on PR #39088: URL: https://github.com/apache/shardingsphere/pull/39088#issuecomment-4957218551
### Summary **Review Result: Mergeable** **Reason:** This is a code-scope result; CI not reviewed by request. The PR completes the remaining Simplified Chinese documentation correction for the already-merged `proxy_state` metric fix, with no code-level blocker found. ### Evidence - The base already contains the production and English documentation corrections from [PR #39079](https://github.com/apache/shardingsphere/pull/39079). - This PR removes the obsolete `2 锁定状态` text from [`_index.cn.md:127`](https://github.com/terrymanu/shardingsphere/blob/1e05ea9ed86512bbb4aa2c82d620c8cc97d46c77/docs/document/content/user-manual/shardingsphere-proxy/observability/_index.cn.md#L127). - The synthetic merge tree applies cleanly and leaves both English and Simplified Chinese observability pages consistent with the two-state `InstanceState` model. - No runtime behavior, metric identity, labels, values, or public API is changed. No additional test is needed for this documentation-only change. ### Review Details - Review Focus: Code Correctness Review — CI not reviewed by request. - Reviewed Scope: `docs/document/content/user-manual/shardingsphere-proxy/observability/_index.cn.md` at head `1e05ea9ed86512bbb4aa2c82d620c8cc97d46c77`; base `master` at `c1978128d4a5ae0b0c4b39a7b88de5e85a1a3bbf`; local merge-base `497fb3121dab5fdff9fd4ec1be1d05894f94da84`. The local file list matched GitHub `/pulls/39088/files`. - Not Reviewed Scope: GitHub Actions/check-runs, live documentation rendering, and unrelated modules. - Verification: Review inventory exited `0`; synthetic merge-tree verification exited `0`; merged-tree scan found no remaining stale `proxy_state` `LOCK`/value-2 references in the proxy metric code or observability documentation. Maven was not run because this PR changes documentation only. GitHub metadata, files, commits, comments, and reviews were accessible. - Release Note / User Docs: Release notes are not required. The Simplified Chinese user documentation update is present and verified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
